On Wed, 11 Nov 2009 10:51:29 -0600
"Stephen M. Cameron" <scameron@xxxxxxxxxxxxxxxxxx> wrote:
> +static void hpsa_scsi_do_simple_cmd_with_retry(struct ctlr_info *h,
> + struct CommandList *c, int data_direction)
> +{
> + int retry_count = 0;
> +
> + do {
> + memset(c->err_info, 0, sizeof(c->err_info));
> + hpsa_scsi_do_simple_cmd_core(h, c);
> + retry_count++;
> + } while (check_for_unit_attention(h, c) && retry_count <= 3);
> + hpsa_pci_unmap(h->pdev, c, 1, data_direction);
> +}
If this times out, no indication of the error is returned to the caller
and no message is displayed to the operator.
Doesn't seem very robust?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
