Hi Dominik, > Most of the irq_req_t typedef'd struct can be re-worked quite > easily: > > (1) IRQInfo2 was unused in any case, so drop it. > > (2) IRQInfo1 was used write-only, so drop it. > > (3) Instance (private data to be passed to the IRQ handler): > Most PCMCIA drivers using pcmcia_request_irq() to actually > register an IRQ handler set the "dev_id" to the same pointer > as the "priv" pointer in struct pcmcia_device. Modify the two > exceptions (ipwireless, ibmtr_cs) to also work this waym and > set the IRQ handler's "dev_id" to p_dev->priv unconditionally. > > (4) Handler is to be of type irq_handler_t. > > (5) Handler != NULL already tells whether an IRQ handler is present. > Therefore, we do not need the IRQ_HANDLER_PRESENT flag in > irq_req_t.Attributes. > > CC: netdev@xxxxxxxxxxxxxxx > CC: linux-bluetooth@xxxxxxxxxxxxxxx > CC: linux-ide@xxxxxxxxxxxxxxx > CC: linux-wireless@xxxxxxxxxxxxxxx > CC: linux-scsi@xxxxxxxxxxxxxxx > CC: alsa-devel@xxxxxxxxxxxxxxxx > CC: Jaroslav Kysela <perex@xxxxxxxx> > CC: Jiri Kosina <jkosina@xxxxxxx> > CC: Karsten Keil <isdn@xxxxxxxxxxxxxx> > Signed-off-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> > --- > drivers/ata/pata_pcmcia.c | 1 - > drivers/bluetooth/bluecard_cs.c | 4 +--- > drivers/bluetooth/bt3c_cs.c | 4 +--- > drivers/bluetooth/btuart_cs.c | 4 +--- > drivers/bluetooth/dtl1_cs.c | 4 +--- for the Bluetooth parts: Acked-by: Marcel Holtmann <marcel@xxxxxxxxxxxx> Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
