Re: [PATCH 6/7]MVSAS: Enhanced hot plug handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+
spin_unlock_irqrestore(dev->sata_dev.ap->lock,
+						flags_libsas);
+				spin_unlock_irqrestore(&mvi->lock, flags);
+				t->task_done(t);
+				spin_lock_irqsave(&mvi->lock, flags);
+				spin_lock_irqsave(dev->sata_dev.ap->lock,
+					flags_libsas);


[Jack] Is there something wrong with the the lock sequence .
for sata io path, will __acquires(dev->sata_dev.ap->lock) when issue cmd to
lldd
and you acquires your mvi lock then, so should you change the lock sequence
to :


spin_unlock_irqrestore(&mvi->lock, flags);
spin_unlock_irqrestore(dev->sata_dev.ap->lock,
						flags_libsas);
t->task_done(t);
spin_lock_irqsave(dev->sata_dev.ap->lock,
					flags_libsas);
spin_lock_irqsave(&mvi->lock, flags);



--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux