On Thu, 2009-11-05 at 10:29 +0200, Boaz Harrosh wrote: > On 11/04/2009 07:50 PM, James Bottomley wrote: > > On Wed, 2009-11-04 at 18:18 +0200, Boaz Harrosh wrote: > > > > The point of checking is not to send a VPD inquiry to USB devices that > > don't support it. These have a very limited range of supported VPD > > pages. > > > > OK thanks. But maybe just define a MIN_INQUIRY_SIZE instead of hard > coded 32 everywhere, and use that. So in future if such a device is > found we can easily change it. So the minimum inquiry size would actually be 36 ... from scsi_scan.c ... and that's hard coded to a value too. > (Never say never ;-)) I'm hoping that by the time USB devices get complex enough to need more than 28 VPD pages, they've actually discovered what conforming to the standards means. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
