Re: [PATCH 1/2] block: Expose discard granularity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 03 2009, Christoph Hellwig wrote:
> On Mon, Nov 02, 2009 at 08:31:08AM -0500, Martin K. Petersen wrote:
> > They all follow the block layer calling conventions.  They are also
> > there to prevent the disaster that was the topology merge which exposed
> > code all over the kernel that was poking directly at fields in struct
> > request.
> 
> It's pretty nasy historic conventions we don't follow anywhere else.
> If Jens insist on keeping the obsfucation we of course have to, but
> recently even the block layer moved away from all that wrapping.

I'm not too fond of it either, I have no problems removing the wrappers.
They are transitionally useful as Martin points out, but in the long run
we should simply get rid of them as they hinder code readability.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux