Re: [PATCH] Add missing #include for include/scsi/osd_protocol.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/31/2009 11:33 AM, Martin Michlmayr wrote:
> include/scsi/osd_protocol.h is missing an #include, leading to:
> | include/scsi/osd_protocol.h:277: error: implicit declaration of function '__constant_cpu_to_be16'
> | include/scsi/osd_protocol.h:362: error: implicit declaration of function 'ALIGN'
> 

I cannot reproduce this problem. What platform  (ARCH/config) are you compiling
this?

Because you see I have a source file in the tree that has this #include as very
first include. And it has been compiling in Kernel and in -next for a long time.
(drivers/scsi/osd/osd_initiator.c has osd_initiator.h as first header which has
 osd_protocol.h as first header.)

> Signed-off-by: Martin Michlmayr <tbm@xxxxxxxxxx>
> 
> --- a/include/scsi/osd_protocol.h	2009-10-31 09:19:28.000000000 +0000
> +++ b/include/scsi/osd_protocol.h	2009-10-31 09:27:42.000000000 +0000
> @@ -17,6 +17,7 @@
>  #define __OSD_PROTOCOL_H__
>  
>  #include <linux/types.h>
> +#include <linux/kernel.h>
>  #include <asm/unaligned.h>

>From what I can see, asm/unaligned.h eventually pulls kernel.h through
one of it's possible implementations. Do you have a special asm/unaligned.h?

>  #include <scsi/scsi.h>
>  
> 

Please help me reproduce this problem.

Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux