On 10/29/2009 08:03 PM, James Bottomley wrote: > On Thu, 2009-10-29 at 19:50 +0200, Boaz Harrosh wrote: >> Some thing like below. >> >> There is to much knolage of device in my opinion. To much fidling >> of private device members. What when some new members are added? > > What private device members ... the pieces you fill in are the public > ones. If you want a macro to do that, I'm sure Greg would be > amenable ... > >> I hate it. > > Because you have to type six more lines of code? To me it looks cleaner > because there's only a single allocation instead of two and now no need > of chaining destructors because everything goes together thus making the > lifetime rules more obvious and robust. > > It also saves memory because it has two fewer pointers. > > James > OK I'll roll up a patch that introduces a device_init helper and a patch for Greg that exchanges my helper with an export. But I will have to test it so only next week. Thanks for the review. Is that the only thing? Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
