On Wed, 2009-10-28 at 22:48 +0000, James Bottomley wrote: > On Thu, 2009-10-15 at 17:46 -0700, Vasu Dev wrote: > This still doesn't build: > > drivers/scsi/53c700.c: In function 'NCR_700_detect': > drivers/scsi/53c700.c:331: warning: assignment from incompatible pointer type > drivers/scsi/53c700.c: At top level: > drivers/scsi/53c700.c:2085: error: conflicting types for 'NCR_700_change_queue_depth' > drivers/scsi/53c700.c:178: error: previous declaration of 'NCR_700_change_queue_depth' was here > Too bad, I tried "make allmodconfig" again after "make distclean" on x86_64 but again it didn't catch this error since it didn't compile 53c700.c once again, so any trick to really force all modules compilation to catch such errors in future ? > It looks like just an unconverted function prototype, so the patch below fixes it. > Thanks James for the fix and I suppose I don't need to send updated patch again with your fix since probably you will roll this fix into this patch when applying this patch. Vasu -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html