Joe Eykholt wrote:
Vasu Dev wrote:
On Tue, 2009-10-20 at 20:54 +0200, Christof Schmitt wrote:
I would prefer having seconds or milliseconds in sysfs and only using
jiffies internally.
Added timestamp comparison checks are straightforward without any
additional conversion on each check since added timestamps and
queue_ramp_up_period both are jiffies, so works better this way with
stored queue_ramp_up_period in jiffies.
I do see your point as well but jiffies unit is also common in Linux.
However if you or some other feels strongly to change this to ms or
seconds unit then I could change store or show sysfs functions to handle
this value in ms or second unit while storing it in jiffies in
queue_ramp_up_period.
Vasu
I agree with Christof on this, HZ may be 100 on some machines and 1000
on others. Management tools (if they ever adjust this) would like
standard units, so it should be in ms or seconds, and I prefer ms.
I would just change the sysfs functions as you say, and use jiffies internally.
Joe
I'll third this request - specifying in jiffies is a non-distinct value from
platform to platform. ms or seconds is preferred.
-- james
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
