On Tue, 2009-10-13 at 16:59 -0500, James Bottomley wrote: > OK, so this patch series isn't bisectable. If I just apply 1 it > won't > compile. > > To get to bisectability it looks like patches 1,3,4 need combining. It Only 4 needs to be combined with 1 due to change_queue_depth() func params change in 1 and all impacted drivers by this change are modified later in patch 4 breaking patch 1. The patch 3 depended on 2, so 3 cannot be merged w/o 2, so I'll leave them as-is. > also looks like 5,6,7 are all really the same change, so could be > combined. > Yes can be since all for added common ramp up code. I kept existing code changes separate in 5 and 6 to help in review. I'm combining them as well. Also adding one more related change as max_queue_depth field per sdev to track max qdepth per sdev, so that ramp up won't exceed max_queue_depth which could be modified via sysfs to limit qdepth on a sdev. > Could you repost with at least the bisectability fixed? > I'm posting revised series with each bisectable patch on scsi-misc current top commit:- commit bfa27150c1ba70e2cb2d3b738025ec4803f4101e Author: Jing Huang <huangj@xxxxxxxxxxx> Date: Fri Sep 25 12:29:54 2009 -0700 [SCSI] bfa: fixed checkpatch errors for bfad files Thanks Vasu -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
