Re: [PATCH] NCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 06 Oct 2009 22:17:43 +0200
Roel Kluin <roel.kluin@xxxxxxxxx> wrote:

> Besides keeping the line short, the second setting of the
> MR_DMA_MODE bit was removed.
> 
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> Please review, maybe some other bit should be set?

The only ones left are MR_BLOCK_DMA_MODE and MR_ARBITRATE.

No, I don't know if they hould have been set either.  Let that sleeping
dog lie, I suspect.


> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index f92da9f..5d2f148 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1857,7 +1857,9 @@ static int NCR5380_transfer_dma(struct Scsi_Host *instance, unsigned char *phase
>  #endif
>  	/* KLL May need eop and parity in 53c400 */
>  	if (hostdata->flags & FLAG_NCR53C400)
> -		NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE | MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR | MR_ENABLE_EOP_INTR | MR_DMA_MODE | MR_MONITOR_BSY);
> +		NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE |
> +				MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR |
> +				MR_ENABLE_EOP_INTR | MR_MONITOR_BSY);
>  	else
>  		NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE);
>  #endif				/* def REAL_DMA */
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux