This patch looks good. Thanks Mike. Acked-by: James Smart <james.smart@xxxxxxxxxx> -- james s Michael Reed wrote:
I was doing some large lun count testing with 2.6.31 and hit a BUG_ON() in fc_timeout_deleted_rport(), and it seems like it should have been just a matter of time before someone did. It seems invalid to set port_state under lock, then expect it to remain set after releasing the lock. Another thread called fc_remote_port_add() when the lock was released, changing the port_state. This patch removes the BUG_ON and moves the test of the port_state to inside the host_lock. It's been running for several weeks now with no ill effect. Applies to 2.6.31 and 2.6.32-rc3. Signed-off-by: Michael Reed <mdr@xxxxxxx> --- a/drivers/scsi/scsi_transport_fc.c 2009-09-09 17:13:59.000000000 -0500 +++ b/drivers/scsi/scsi_transport_fc.c 2009-10-02 15:09:00.298487474 -0500
-- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
