I have put in that code as infrastructure needed when we implement the blob that we had discussed. Yes, it needs the changes in scsi_transport_iscsi ,then, I will call the mgmt_fw_cmd ----- Original Message ----- From: Mike Christie [mailto:michaelc@xxxxxxxxxxx] To: Jayamohan Kalickal [mailto:jayamohank@xxxxxxxxxxxxxxxxx] Cc: linux-scsi@xxxxxxxxxxxxxxx Sent: Mon, 12 Oct 2009 20:12:31 -0700 Subject: Re: [PATCH 1/1] be2iscsi: Enabling MSIX and mcc_rings > Jayamohan Kallickal wrote: > > This patch adds > > > > 1) Turns on msix > > 2) mcc_ring support for sending FW commands > > 3) Support for Ring Mode of WRB Posting > > > > > > > +struct be_mgmt_fw_cmd_info { > > + struct be_cmd_req_hdr hdr; > > + void *pdata_buffer; > > + unsigned int data_length; > > +} __packed; > > + > > +struct be_mgmt_fw_cmd_info_resp { > > + struct be_cmd_resp_hdr hdr; > > + void *pdata_buffer; > > + unsigned int data_length; > > +} __packed; > > + > > + > > Did you meant to send another patch with this one or did you not mean to > include the mgmt_fw code in here? be_mgmt_fw_cmd_info_resp is not used > and be_mgmt_fw_cmd_info is used in mgmt_fw_cmd, but that function is > never called. > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > ___________________________________________________________________________________ This message, together with any attachment(s), contains confidential and proprietary information of ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized review, printing, retention, copying, disclosure or distribution is strictly prohibited. If you are not the intended recipient of this message, please immediately advise the sender by reply email message and delete all copies of this message and any attachment(s). Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html