On Fri, Oct 09, 2009 at 11:57:46AM +0530, Sachin Sant wrote:
> @@ -2884,6 +2884,7 @@ static bool ahci_broken_online(struct pc
> return pdev->bus->number == (val >> 8) && pdev->devfn == (val & 0xff);
> }
>
> +#ifdef CONFIG_ATA_ACPI
> static void ahci_gtf_filter_workaround(struct ata_host *host)
> {
> static const struct dmi_system_id sysids[] = {
> @@ -2927,6 +2928,7 @@ static void ahci_gtf_filter_workaround(s
> dev->gtf_filter |= filter;
> }
> }
> +#endif
>
> static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> {
> @@ -3093,8 +3095,10 @@ static int ahci_init_one(struct pci_dev
> /* apply workaround for ASUS P5W DH Deluxe mainboard */
> ahci_p5wdh_workaround(host);
>
> +#ifdef CONFIG_ATA_ACPI
> /* apply gtf filter quirk */
> ahci_gtf_filter_workaround(host);
> +#endif
The usual way to do this is to make sure there's a dummy
ahci_gtf_filter_workaround so there doesn't have to be that ifdef in
the caller. This is probably easier to do like this:
@@ -2884,6 +2884,7 @@ static bool ahci_broken_online(struct pc
return pdev->bus->number == (val >> 8) && pdev->devfn == (val & 0xff);
}
static void ahci_gtf_filter_workaround(struct ata_host *host)
{
+#ifdef CONFIG_ATA_ACPI
static const struct dmi_system_id sysids[] = {
@@ -2927,6 +2928,7 @@ static void ahci_gtf_filter_workaround(s
dev->gtf_filter |= filter;
}
+#endif
}
static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
{
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
