> On Fri, 25 Sep 2009, Kai Makisara wrote:
>
> Having thought this a little more, it would probably be best to remove
> the
> call to normalize_buffer() instead of trying to cope with it failing.
> This
> just means that some memory may stay allocated longer. In the usage
> scenarios coming into my mind, the buffer is either small or it will
> be
> reallocated.
>
> Would you like to make the patch?
>
> Thanks,
> Kai
How does this look? Compiles and passes initial tests. I'd left the
normalize_buffer() in originally thinking there must be a reason for
it, but you're right it just seems to make buffer handling problematic.
This patch removes the normalize_buffer() call and the specialness of
changing from a 0 to non-zero blocksize to fix the possible use of
memory after it has been freed by the st driver.
signed-off-by: David Jeffery <djeffery@xxxxxxxxxx>
--- a/drivers/scsi/st.c 2009-09-28 13:29:31.000000000 -0400
+++ b/drivers/scsi/st.c 2009-09-28 13:35:32.000000000 -0400
@@ -2859,11 +2859,8 @@
ioctl_result = st_int_ioctl(STp, MTBSF, 1);
if (cmd_in == MTSETBLK || cmd_in == SET_DENS_AND_BLK) {
- int old_block_size = STp->block_size;
STp->block_size = arg & MT_ST_BLKSIZE_MASK;
if (STp->block_size != 0) {
- if (old_block_size == 0)
- normalize_buffer(STp->buffer);
(STp->buffer)->buffer_blocks =
(STp->buffer)->buffer_size / STp->block_size;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
