Daniel, Thanks Daniel. Let me verify if this copy/paste did those changes. Bo Yang -----Original Message----- From: Daniel Walker [mailto:dwalker@xxxxxxxxxx] Sent: Monday, September 21, 2009 11:57 AM To: Yang, Bo Cc: James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; James.Bottomley@xxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: RE: [PATCH 1/12] scsi: megaraid_sas - tape drive support fix On Mon, 2009-09-21 at 09:22 -0600, Yang, Bo wrote: > Daniel, > > Thanks for viewing the patches. I did run the checkpatch.pl first before I submit the patches. Is there possible you can tell me the errors in the specific patch, I need to find out if it is my e-mail setting problems or something else. There are problems in all your patches.. >From patch 1 (not all the errors), ERROR: patch seems to be corrupt (line wrapped?) #73: FILE: drivers/scsi/megaraid/megaraid_sas.c:686: memcpy(pthru->cdb, scp->cmnd, scp->cmd_len); ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 #76: FILE: drivers/scsi/megaraid/megaraid_sas.c:688: + * If the command is for the tape device, set the ^ ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 #77: FILE: drivers/scsi/megaraid/megaraid_sas.c:689: + * pthru timeout to the os layer timeout value. >From patch 2, WARNING: suspect code indent for conditional statements (7, 15) #107: FILE: drivers/scsi/megaraid/megaraid_sas.c:1306: + if ((!cmd->abort_aen) && (instance->unload == 0)) { + spin_lock_irqsave(&poll_aen_lock, flags); ERROR: code indent should use tabs where possible #108: FILE: drivers/scsi/megaraid/megaraid_sas.c:1307: + spin_lock_irqsave(&poll_aen_lock, flags);$ ERROR: code indent should use tabs where possible #109: FILE: drivers/scsi/megaraid/megaraid_sas.c:1308: + megasas_poll_wait_aen = 1;$ Actually, now that I look closer, other than the errors from patch 1 the rest of the patches have warnings similar to patch 2.. Did you do some type of copy&paste to put the patches into each email? Often times that will remove all the tabs which could cause the errors above. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
