On Fri, 2009-09-18 at 15:07 -0700, Nicholas A. Bellinger wrote: > Greetings all, > > This is the second round of request for comments for TCM/ConfigFS v3.2 > from lio-core-2.6.git. > Thanks to the folks who made comments, and I again invite people to > take a look and make > recommendations on how the code can be futher improved to use the best > available upstream > interfaces. There are still a couple of minor checkpatch errors in the series, but it's nothing you would need to resubmit because of .. In patch 2 the following are fixable, ERROR: return is not a function, parentheses are not required #3401: FILE: include/target/configfs_macros.h:104: + return((ci) ? container_of(to_config_group(ci), struct _item, \ ERROR: trailing whitespace #3438: FILE: include/target/configfs_macros.h:141: +CONFIGFS_EATTR_OPS_STORE(_name, _item);^I$ and in Patch 18, and 19 there are a couple more whitespace related errors you could fix.. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html