On Fri, 2009-09-11 at 19:37 -0700, Daniel Walker wrote: > On Fri, 2009-09-11 at 18:55 -0700, Nicholas A. Bellinger wrote: > > There is cleanup work continuing to make the TCM code to use > > dprintk(), > > and some include cleanups, and other minor fixes. The code has also > > been run through checkpatch again since the posting in April, and all > > errors have been removed, with the exception of one ConfigFS macro > > define triggering a checkpatch false positive. > Greetings Daniel, > > One show stopping issue is that your adding new semaphore usage in patch > 5 and 16 (and in 16 it's a LOCKED one wtf!!). Which you should not be > doing .. You need to really evaluate the warnings from checkpatch, cause > those still have meaning.. > Ok, I will have a look at converting the HBA semaphore to a mutex in patch 5, and use some single use waitqueues in patch 16. Btw, the ones using init_MUTEX_LOCKED() in the latter source file are being used when shutting down target_core_mod allocated kernel threads to sychronize between the stopping processing threads and configfs process context that waitqueues would work better for. Thanks for pointing this out! > It's basically telling you what you should be doing in the warnings.. > For instance, don't add new semaphore usage, and it tells you what you > need to be using in place of them.. Ok, so I will also do the struct sempahore -> struct mutex conversion where it makes sense to protect lists and see about the rest.. > Also typedefs are frowned upon, so > you could remove those.. > I was thinking about going through the typedefs with a sed chainsaw, but I decided against for this TCM patch series because it makes keeping backward ports to <= v2.6.31 slightly easier to maintain for me for the current users of LIO kernel code. However, I have been starting to not use typedef for the newest ALUA and pieces of PR code, and I would be happy to have another look at typedef style comments on this once the other larger interest items are on the way to being resolved. Thanks! --nab > Daniel > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
