On Fri, 2009-09-11 at 11:31 -0500, Mike Christie wrote:
> > + /*
> > + * Walk all devices of a target and do
> > + * ramp up on them.
> > + */
> > + shost_for_each_device(tmp_sdev, sdev->host) {
> > + if ((tmp_sdev->channel != sdev->channel) ||
> > + (tmp_sdev->id != sdev->id))
> > + continue;
>
> I just noticed that while on the ramp down we just check the id, but
> why
> on the ramp up do we check the channel and id?
>
Currently qla2xxx does ramp down on all luns of a target using
starget_for_each_device, so I added check for channel also just as
starget_for_each_device does. The ramp down should be doing same, I'll
add channel check to ramp down code also.
> Do we just want to adjust the devices on one specific target? If so is
> starget_for_each_device() better to use?
I considered that but call back parameters in starget_for_each_device
were not compatible with required parameters to change_queue_depth call
back, later starget_for_each_device should be fixed to use it here also
and that would be another API change.
Thanks
Vasu
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
