Jayamohan Kalickal wrote:
Ok. Reading Mike's comment once again and looking at the lpfc code ,I think, maybe, this is what Mike had in mind, but I could have misunderstood.
During session create, I will create the pool as well as alloc. This will take
care of the allocation at page level and scarce coherent resources problems
mentioned by JamesB. Also, this would not have any impact on performance. I see this
done for "lpfc_mbuf_pool" in lpfc/lpfc_mem.c.
Thanks
Jay
As most things - it depends on what's being allocated. I recommended against
a pci pool when I was looking at the allocations for queue memory, SGLs, etc
as that is largely static (allocate/assign once, rarely dealloc/deassign) and
very much likes to be 4k pages, page aligned, and as contiguous as possible.
However, the DMA buffers for the Command and Response buffers is a different
story. They are in the fast path, re-alloc per command, are smaller than a
page, etc and fit the pci pool profile very well.
-- james s
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
