On Wed, 2009-09-09 at 12:15 -0700, Jayamohan Kalickal wrote: > Implementing pci_pool is not a problem. But, my experience with this chip > (or for that matter any chip that can do huge IOPS ,say, more then 600 -700 KIOPS), > every line of code on the hot path would have an impact and hence I strive to > move it out of the hot path. > > The code is not yet optimized for speed yet but I definitely want to push whatever > I can to init time from the IO path. I'll fold in the patch as is because we urgently need a fix for the virt_to_bus() problem. pci_pool was designed to allow for good IOP throughput (that's why lpfc is using it). The pci_alloc_consistent() you've chosen often only allocates at the page level, so it can be hugely wasteful of resources; plus coherent memory is a precious resource on some platforms, so I can see you running out on them. Could you at least try a pci_pool implementation ... if it really turns out to be a performance problem we can keep the current implementation despite the potential resource issues. Thanks, James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
