On Fri, 28 Aug 2009 00:54:30 -0700 Jing Huang <huangj@xxxxxxxxxxx> wrote: > From: Jing Huang <huangj@xxxxxxxxxxx> > > This patch contains code that interfaces to upper layer linux kernel, such as > PCI, SCSI mid-layer and sysfs etc. > These patches seem to have been posted a lot of times. Is anyone paying attention? > +BFA_TRC_FILE(LDRV, BFAD); > + > +static DEFINE_MUTEX(bfad_mutex); > +int bfad_scan_done; > + > +LIST_HEAD(bfad_list); > + > +static int bfad_inst; > +int supported_fc4s; > + > +char *host_name; > +char *os_name; > +char *os_patch; > +int num_rports; > +int num_ios; > +int num_tms; > +int num_fcxps; > +int num_ufbufs; > +int reqq_size; > +int rspq_size; > +int num_sgpgs; > +int rport_del_timeout = BFA_FCS_RPORT_DEF_DEL_TIMEOUT; > +int bfa_lun_queue_depth = BFAD_LUN_QUEUE_DEPTH; > +int bfa_io_max_sge = BFAD_IO_MAX_SGE; > +int log_level = BFA_LOG_WARNING; > +int ioc_auto_recover = BFA_TRUE; > +int ipfc_enable = BFA_FALSE; > +int ipfc_mtu = -1; > +int linkup_delay = -1; eek. These are all kernel-wide global symbols and many of them are very inappropriately named. They should either be made static or given a subsystem-specific prefix such as "bfad_". -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
