Hi James, On Tue, Sep 1, 2009 at 7:23 AM, James Bottomley<James.Bottomley@xxxxxxx> wrote: > On Mon, 2009-08-31 at 14:53 -0700, Alok Kataria wrote: >> Hi James, >> >> Thanks for your comments. >> >> On Mon, 2009-08-31 at 11:00 -0700, James Bottomley wrote: >> > On Mon, 2009-08-31 at 10:28 -0700, Alok Kataria wrote: >> > > VMware PVSCSI driver - v2. >> > >> > OK, so the first thing that springs to mind is that we already have one >> > of these things: the ibmvscsi ... is there no way we can share code >> > between this and the other PV drivers? >> >> I took a quick look at the ibmvscsi driver, and there are lot of >> differences between the two, mainly the ABI that is shared between the >> hypervisor and driver differ. > > Well, that's pretty abstractable, surely? However, there is an > interesting question of what the best hypervisor interface actually is. > >> Also the ibmvscsi driver seems to offer a >> lot of other features as well, like the SRP. > > SRP is the protocol transfer abstraction. It's just a way of packaging > up SCSI commands for transfer over a DMA protocol (OK, so it was > envisaged that the DMA protocol would be RDMA, but a hypervisor > interface is also a DMA protocol). > >> The pvscsi driver is a simple SCSI adapter driver and is basically no >> different than any other SCSI driver written for a particular HBA. > > Well, it is really ... hopefully all the hypervisor interfaces won't > decide to be completely incompatible, so there's a good chance of code > sharing between them. Well, going by that theory every SCSI driver can share some code with any other SCSI driver, In short we can come up with an low level SCSI driver interface which every SCSI driver can make use of, to reduce code duplicity. We don't do that, and the reason being, that its a device and we shouldn't expect every device to share common features or design decisions. We already virtualize storage at the lowest (read device) level to avoid duplicating stuff in a guest operating system. If this was say a block level virtaulizing scheme sharing would be more eminent, but given that we are a device its better to keep things separate and IMHO, it might be an overkill to design a new pv-driver or some such layer for every device that you virtualize. Thanks, Alok > > James > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
