Re: [PATCH 4/6] RFC: beiscsi: iscsi hook in and handling code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jayamohan Kalickal wrote:
  > +
  > + cls_session =
  > +  iscsi_session_setup(&beiscsi_iscsi_transport, shost, cmds_max,
Was there any limit on the number of commands per session? What about
  per port/scsi_host?
     The maximum number of commands is the queuedepth. Yes , we have a limit per port(scsi_host ) as well.  Am I required to specify them here. I haven't understood the comment.


I was actually just asking because I was curious and because I was wondering about what was going on below.

The host limit should just get set in scsi_host_template->can_queue (you did this already). Then nelow you do not want to set the shost->can_queue to cmds_max.

Did the queuedepth comment mean you have a per session limit too? If so then you at least want to do a min(cmds_max, your_max_queue_depth) to make sure the iscsi layer does not send more commands than you can handle.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux