On Sat, 22 Aug 2009 19:05:52 +0200 Roel Kluin <roel.kluin@xxxxxxxxx> wrote: > unmap ccb_phys as well when scsi_add_host() fails > > Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> > --- > Right? Partially. > diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c > index 185e6bc..3111503 100644 > --- a/drivers/scsi/gdth.c > +++ b/drivers/scsi/gdth.c > @@ -4903,7 +4903,7 @@ static int __init gdth_eisa_probe_one(ushort eisa_slot) > > error = scsi_add_host(shp, NULL); > if (error) > - goto out_free_coal_stat; > + goto out_free_ccb_phys; > list_add_tail(&ha->list, &gdth_instances); > gdth_timer_init(); > I suspect that we should also undo the effects of gdth_enable_int() if taking this path. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
