On Fri, 2009-08-21 at 23:59 +0100, Chris Webb wrote: > James Bottomley <James.Bottomley@xxxxxxx> writes: > > > Can you try this as a partial fix? (It should prevent the oops, but > > you'll still lose the disk). > > Hi James. Many thanks for this. Do you think it's worth adding a printk() to > flag up when this happens so we can detect when this case happens and > confirm the issue given how rare the crashes are, or is this difficult to > arrange? Well, it's only a theory, so we need confirmation that it actually fixes the problem. As for a printk, there's no real way to do that. What I did was make sure we take a reference to the scsi disk. Holding that reference should prevent us from losing the partition table ... but the issue itself is legitimate (add racing with remove), and there's not really a good way of detecting it. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html