From: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
Don't use kfree directly after device registration started.
Signed-off-by: Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Christof Schmitt <christof.schmitt@xxxxxxxxxx>
---
drivers/s390/scsi/zfcp_aux.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
--- a/drivers/s390/scsi/zfcp_aux.c 2009-08-17 11:30:21.000000000 +0200
+++ b/drivers/s390/scsi/zfcp_aux.c 2009-08-17 11:30:23.000000000 +0200
@@ -309,8 +309,10 @@ struct zfcp_unit *zfcp_unit_enqueue(stru
}
read_unlock_irq(&zfcp_data.config_lock);
- if (device_register(&unit->sysfs_device))
- goto err_out_free;
+ if (device_register(&unit->sysfs_device)) {
+ put_device(&unit->sysfs_device);
+ return ERR_PTR(-EINVAL);
+ }
if (sysfs_create_group(&unit->sysfs_device.kobj,
&zfcp_sysfs_unit_attrs)) {
@@ -675,8 +677,10 @@ struct zfcp_port *zfcp_port_enqueue(stru
}
read_unlock_irq(&zfcp_data.config_lock);
- if (device_register(&port->sysfs_device))
- goto err_out_free;
+ if (device_register(&port->sysfs_device)) {
+ put_device(&port->sysfs_device);
+ goto err_out;
+ }
retval = sysfs_create_group(&port->sysfs_device.kobj,
&zfcp_sysfs_port_attrs);
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
