From: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> Date: Fri, 14 Aug 2009 15:42:39 -0700 > From: Yi Zou <yi.zou@xxxxxxxxx> > > Add ndo_fcoe_control to net_device_ops so the corresponding HW can initialize > itself for FCoE traffic or clean up after FCoE traffic is done. This is > expected to be called by the kernel FCoE stack upon receiving a request for > creating an FCoE instance on the corresponding netdev interface. When > implemented by the actual HW, the HW driver check the op code to perform > corresponding initialization or clean up for FCoE. The initialization normally > includes allocating extra queues for FCoE, setting corresponding HW registers > for FCoE, indicating FCoE offload features via netdev, etc. The clean-up would > include releasing the resources allocated for FCoE. > > Currently, there are two defined op codes as NETDEV_FCOE_DISABLE and _ENABLE, > for initialization and cleanup accordingly. > > Signed-off-by: Yi Zou <yi.zou@xxxxxxxxx> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx> And here is where I stop applying patches. This is not the way to do this. Having a vague "_control" operation with command codes is almost as bad as ioctl(). Instead, add explicit ->ndo_fcoe_enable() and ndo_fcoe_disable() operations. Any other "control" commands you would add would probably need parameters, and then this method would be a tangled web of misc parameter slots and an even more tangled web of semantics. Please resubmit the rest of this series once this issue is corrected. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
