RE: [PATCH 4/7] mpt2sas: setting SDEV into RUNNING state from Interrupt context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, August 14, 2009 9:11 AM,  James Bottomley wrote: 
> 
> OK, so explain these functions _scsih_ublock_io_device and
> _scsih_block_io_device to me.  You're wrongly tampering with device
> state in them ... it should be using the block/unblock functions in
> scsi_lib.c if it's a standard usage.  If not, it shouldn't be touching
> the device state, especially SDEV_BLOCK, because that has 
> queue running
> and plugging implications.
> 

This is for failover/fail back.  I overlooked using scsi_device_set_state,  I assume that is what your refering to.  I guess I had been looking at old fc transport code.

Eric  --
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux