Roel Kluin wrote: > If `sglist->num_dma_sg' is zero we write ioadl[-1] > > Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> > --- > Is it possible for sglist->num_dma_sg to be 0? No. Its not possible. The code in ipr_update_ioa_ucode ensures this. Thanks, Brian > > diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c > index 5f04550..736ad07 100644 > --- a/drivers/scsi/ipr.c > +++ b/drivers/scsi/ipr.c > @@ -3004,8 +3004,9 @@ static void ipr_build_ucode_ioadl(struct ipr_cmnd *ipr_cmd, > cpu_to_be32(sg_dma_address(&scatterlist[i])); > } > > - ioadl[i-1].flags_and_data_len |= > - cpu_to_be32(IPR_IOADL_FLAGS_LAST); > + if (i != 0) > + ioadl[i-1].flags_and_data_len |= > + cpu_to_be32(IPR_IOADL_FLAGS_LAST); > } > > /** > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Brian King Linux on Power Virtualization IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
