Re: [PATCH] drivers/scsi: Check NULL for kmalloc() return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 7 Aug 2009, Davidlohr Bueso A. wrote:

> On Fri, Aug 07, 2009 at 08:54:44PM +0200, Julia Lawall wrote:
> > On Fri, 7 Aug 2009, Davidlohr Bueso A. wrote:
> > 
> > > Verify that ch->dt is not NULL before using it:
> > > ch-dt[elem] = value;
> > 
> > It looks like buffer should be freed as well?
> 
> The way I see it, this is done in ch_remove()

I don't see that at all.  buffer appears to be a variable that is local to 
ch_readconfig and is passed down to other functions, but never saved 
anywhere.  Furthermore buffer is freed in the normal exit of the function, 
so it seems likely that it should be freed on an early exit as well.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux