Re: [PATCH 2/3] libata: Bind the Linux device tree to the ACPI device tree

[Håkon Løvdal <hlovdal@xxxxxxxxx>]

2009/7/13 Matthew Garrett <mjg@xxxxxxxxxx>:
> +               if (!sata_pmp_attached(ap))
> +                       adr = SATA_ADR(ap->port_no, NO_PORT_MULT);
> +               else
> +                       adr = SATA_ADR(ap->port_no, dev->link->pmp);

Maybe I am missing something, but wouldn't it be more natural to write this as

        if (sata_pmp_attached(ap))
                adr = SATA_ADR(ap->port_no, dev->link->pmp);
        else
                adr = SATA_ADR(ap->port_no, NO_PORT_MULT);

BR Håkon Løvdal
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html