While trying to replace the Fibre Channel protocol definitions in zfcp with the definitions in include/scsi/fc i came across the FCP target reset flag. >From what i understand, older versions of the FCP standard defined the target reset flag, but newer versions do not. Adhering to the newer standard, the file include/scsi/fc/fc_fcp.h does not define the target reset. Does this mean that FC device drivers should not issue target resets any more? Some FC device drivers in Linux define the flag: grep -r FCP_TARGET_RESET * drivers/s390/scsi/zfcp_dbf.h: zfcp_scsi_dbf_event(flag == FCP_TARGET_RESET ? "trst" : "lrst", tag, 1, drivers/s390/scsi/zfcp_def.h:#define FCP_TARGET_RESET 0x20 drivers/s390/scsi/zfcp_scsi.c: return zfcp_task_mgmt_function(scpnt, FCP_TARGET_RESET); drivers/scsi/lpfc/lpfc_scsi.c: FCP_TARGET_RESET); drivers/scsi/lpfc/lpfc_scsi.c: FCP_TARGET_RESET); drivers/scsi/lpfc/lpfc_scsi.h:#define FCP_TARGET_RESET 0x20 /* bit 5 */ If the target reset is not required, i would remove it from zfcp. If it is still required, would adding it to include/scsi/fc/fc_fcp.h make sense, probably flagged as "obsolete"? -- Christof Schmitt -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
