On Fri, Jul 24, 2009 at 10:10:26PM -0400, Dave Jones wrote: > +++ b/include/scsi/scsi.h > @@ -156,7 +156,9 @@ scsi_varlen_cdb_length(const void *hdr) > return ((struct scsi_varlen_cdb_hdr *)hdr)->additional_cdb_length + 8; > } > > +#ifdef __KERNEL__ > extern const unsigned char scsi_command_size_tbl[8]; > +#endif > #define COMMAND_SIZE(opcode) scsi_command_size_tbl[((opcode) >> 5) & 7] > > static inline unsigned Probably should move that #endif down -- it's not like userspace can use the COMMAND_SIZE macro (should headers_check also check for this?) Also scsi_command_size() isn't usable by userspace either, since it uses COMMAND_SIZE. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html