On 07/09/2009 03:47 AM, Tejun Heo wrote: > Hello, > > Boaz Harrosh wrote: >>> @@ -1165,6 +1165,7 @@ static int __make_request(struct request_queue *q, struct bio *bio) >>> const unsigned short prio = bio_prio(bio); >>> const int sync = bio_sync(bio); >>> const int unplug = bio_unplug(bio); >>> + const unsigned int ff = bio->bi_rw & REQ_FAILFAST_MASK; >> Perhaps a bio_fail_fast(bio) >> and also an blk_failfast(rq). > > Me not being a big fan of those simple accessors, I want to avoid > adding those especially the use of bio ones are mostly confined to > block layer proper. > OK but at least take care of blk_noretry_request(), at the minimum kill it, and use req->cmd_flags & REQ_FAILFAST_MASK everywhere. > Thanks. > Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
