Op 18-06-09 14:14, Roel Kluin schreef: > Shifting of u8 causes promotion to signed 'int' > > Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> > --- > I believe this was not intentionally? > see http://osdir.com/ml/git/2009-06/msg01347.html ResidCnt = (((u32) DC390_read8 (CtcReg_High) << 16) | Maybe my patch is not right. I cannot reproduce it with: #include <stdio.h> int main() { unsigned long size = 0; unsigned char c = 1; size += c << 24; printf("%lu\n", size); printf("%lu\n", 1 << 24); printf("%u\n", c); return 0; } [roel@zoinx linux-git]$ ./a.out 16777216 16777216 1 Roel -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html