Re: [RFC PATCH 2/4] scsi error: have scsi-ml call change_queue_depth to handle QUEUE_FULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Mike Christie wrote:
This was called because of a "queue full" for one SCSI device. Why do
you decrement the queue depth for all SCSI devices on the same host
and not only for one device?

It should actually do it for only the devices on the same target where the problem occurred. I copied the code from lpfc and qla2xxx and cannot remember the reason why this is done now. I am ccing AndrewV and JamesS.


Agree that it should be localized to the target and not propagated to all targets. Our design issue was choosing how to apply the backoff - did a queue full on a single lun imply the entire target is full ? Thus, should we reduce all luns at that point, or only the lun that saw the queue full. All depends on how fast you want to ramp down the overall situation and how biased things get on multiple luns.. And the same decision on the ramp up - to we raise everyone, or let the luns function independently. Raising everyone too quickly recauses the issue, and why would one hot lun steal capacity/queuing depth for a slow lun ? There's a lot of assumptions being made in this choice on what is the gating resource (the io capacity of the target being equally shared by all luns).

-- james s


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux