Hi, James, Thanks, I've re-submitted the patches to use kref instead. Best regards, Karen -----Original Message----- From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] Sent: Saturday, June 13, 2009 4:53 PM To: Karen Xie Cc: linux-scsi@xxxxxxxxxxxxxxx; open-iscsi@xxxxxxxxxxxxxxxx; michaelc@xxxxxxxxxxx Subject: Re: [PATCH 1/2 2.6.30-rc] cxgb3i -- add a refcnt to track ddp usage On Sat, 2009-06-13 at 14:29 -0700, kxie@xxxxxxxxxxx wrote: > [PATCH 1/2 2.6.30-rc] cxgb3i -- add a refcnt to track ddp usage > > From: Karen Xie <kxie@xxxxxxxxxxx> > > The iscsi ddp functionality could be used by multiple iscsi entities, > add a refcnt to keep track of it, so we would not release it pre-maturely. The code is fine as it stands but, I wonder, would you consider using a kref for this? The reasons are twofold: 1. It's a well understood kernel paradigm that works ... this would be helpful for the far distant time when chelsio no longer wants to maintain this driver. 2. It includes useful and appropriate warnings for common bugs in refcounted code, such as use of a freed reference. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
