On Wed, 10 Jun 2009 12:56:56 -0700
akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Alexey Zaytsev <alexey.zaytsev@xxxxxxxxx>
>
> The members from 'status' in struct sg_io_hdr to the last are used to
> transfer information from kernel to user space. The values that user
> space sets are just ignored.
>
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev@xxxxxxxxx>
> Cc: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
> Cc: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> fs/compat_ioctl.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff -puN fs/compat_ioctl.c~sg_io-dont-perform-unneeded-copy-in-compat-code fs/compat_ioctl.c
> --- a/fs/compat_ioctl.c~sg_io-dont-perform-unneeded-copy-in-compat-code
> +++ a/fs/compat_ioctl.c
> @@ -787,12 +787,6 @@ static int sg_ioctl_trans(unsigned int f
> if (put_user(compat_ptr(data), &sgio->usr_ptr))
> return -EFAULT;
>
> - if (copy_in_user(&sgio->status, &sgio32->status,
> - (4 * sizeof(unsigned char)) +
> - (2 * sizeof(unsigned short)) +
> - (3 * sizeof(int))))
> - return -EFAULT;
> -
> err = sys_ioctl(fd, cmd, (unsigned long) sgio);
>
> if (err >= 0) {
Acked-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
