On Wed, 10 Jun 2009 11:45:14 +0300 Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote: > On 06/10/2009 11:29 AM, FUJITA Tomonori wrote: > > On Wed, 10 Jun 2009 11:15:10 +0300 > > Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote: > >> That is a violation of block API. All block drivers must call > >> blk_end_request(). > > > > Where can I find a documentation about it? > > > > No documentation > > > If not, can you stop claiming a new rule? > > > > The fact that ALL block drivers call it for proper service of ALL ULDS, > does it not make it a rule? BSG SMP code is not ULD. > > If you want to propose a new rule, you need to fix the existing users > > first. > > > > Sorry I missed them. I couldn't even imagine that there will be any. > Will send patches, sorry. I'll take care about it. > >> If they do not, then they can not for example be > >> called from inside Kernel. They relay on special bsg behavior > >> that always uses map_user. > > > > Of course, we send SMP requests only via BSG. SMP is the first reason > > why we invented BSG. > > > > Of course what? Show me the big fat comment that says: > only use from BSG!!! other wise broken block driver. I think that the majority of SCSI people know that. FYI, you live in a land where very few live. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
