Brian King wrote: > James Bottomley wrote: >> On Wed, 2009-06-03 at 09:54 -0500, Brian King wrote: >>> The ibmvscsi driver currently sends the SRP Login before sending the Adapter >>> Info MAD, which can result in commands getting sent to the virtual adapter >>> before we are ready for them. This results in a slight window where the target >>> devices may not behave as expected. Change the order and close the window. >>> >>> Signed-off-by: Brian King <brking@xxxxxxxxxxxxxxxxxx> >>> --- >>> >>> drivers/scsi/ibmvscsi/ibmvscsi.c | 173 +++++++++++++++++++-------------------- >>> 1 file changed, 85 insertions(+), 88 deletions(-) >> This one just doesn't want to apply: >> >> patching file drivers/scsi/ibmvscsi/ibmvscsi.c >> Hunk #4 FAILED at 961. >> Hunk #5 succeeded at 1279 (offset -3 lines). >> Hunk #6 succeeded at 1289 (offset -3 lines). >> 1 out of 6 hunks FAILED -- saving rejects to file >> drivers/scsi/ibmvscsi/ibmvscsi.c.rej >> >> Could you check scsi-misc and see what's up? > > I'll pull it down and take a look. This series should be applied > on top of > > http://marc.info/?l=linux-scsi&m=124388641607027&w=2 > > although I'm not sure that one liner could be causing all the trouble... My guess is its this patch: http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commitdiff;h=16b3858ec967f4d9817f6958cc7a0bf1222355f3 The same change was also included in patch 2 in this series. I'll rediff and resend... Thanks, Brian -- Brian King Linux on Power Virtualization IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html