On Tue, 2 Jun 2009, James Bottomley wrote: > On Tue, 2009-06-02 at 14:05 -0400, Alan Stern wrote: > > This patch (as1252) fixes a bug in the sd probing code. When the > > probe routine was split up into a synchronous and an asynchronous > > part, too much was put into the asynchronous part. It's important > > that all the possible failure modes occur synchronously, so that the > > driver core knows whether the probe was successful even before the > > async part is complete. > > > > Another bug is that device removal has to wait for the async probing > > to finish! The patch addresses both bugs, by moving some code back > > from sd_probe_async() to sd_probe() and by adding a call to > > async_synchronize_full() at the start of sd_remove(). > > > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > > This is pretty much line by line identical to the patch I already > posted, isn't it? If not, help me understand what's different. It is the same except for the very end, where you realized that you had forgotten to wait for the async_synchronize_full() to complete before calling dev_get_drvdata(). If you ever posted a corrected version of the patch, I never saw it. My intention wasn't to steal your thunder or anything like that. It was just to get a final, correct version of the patch into circulation for people to test and for merging. I had (and still have!) no way of knowing whether you ever finished the patch or merged it into any git trees -- it isn't currently in scsi-misc. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
