On Sat, May 23, 2009 at 2:11 PM, Michael Chan <mchan@xxxxxxxxxxxx> wrote: > New iSCSI driver for Broadcom BNX2 devices. ... > +/* > + * iSCSI Async CQE > + */ > +struct bnx2i_async_msg { ... > +#if defined(__BIG_ENDIAN) > + u8 async_event; > + u8 async_vcode; > + u16 param1; > +#elif defined(__LITTLE_ENDIAN) > + u16 param1; > + u8 async_vcode; > + u8 async_event; > +#endif ... Michael, I'm feeling a bit dense and am not seeing why byte data would have to worry about the 32-bit word endianess of the CPU. Can you give an example of why defined(__BIG_ENDIAN) is needed? Normally the _*ENDIAN defines are used for bit fields, not byte fields. Byte data addressable by the CPU (e.g. host memory) is at the same offset regardless of endianness of the CPU. I feel like I'm missing something that should be obvious. thanks, grant -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html