On 05/14/2009 06:55 PM, Boaz Harrosh wrote: > scsi_init_io() fully prepares the command properly. scsi_tgt_lib need > not assign scsi_cmnd members any more. > > Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx> > --- > drivers/scsi/scsi_tgt_lib.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/scsi/scsi_tgt_lib.c b/drivers/scsi/scsi_tgt_lib.c > index 1030327..ef11b4d 100644 > --- a/drivers/scsi/scsi_tgt_lib.c > +++ b/drivers/scsi/scsi_tgt_lib.c > @@ -383,11 +383,6 @@ static int scsi_map_user_pages(struct scsi_tgt_cmd *tcmd, struct scsi_cmnd *cmd, > scsi_release_buffers(cmd); > goto unmap_rq; > } > - /* > - * we use REQ_TYPE_BLOCK_PC so scsi_init_io doesn't set the > - * length for us. > - */ > - cmd->sdb.length = blk_rq_bytes(rq); > > return 0; > Dear TOMO Ping? James I forgot to say this should be for post-merge tree as the use of blk_rq_bytes(rq) was done by Tejun. (Given Tomo's Ack of course) Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html