On 05/19/2009 01:05 PM, Tejun Heo wrote: > Hello, Boaz. > > Just two minor things. > > Boaz Harrosh wrote: >> /* we assume all request payload was transferred, residual == 0 */ >> - req->data_len = 0; >> + req->resid_len = 0; >> >> if (rsp) { >> - rsp_len = blk_rq_bytes(rsp); >> - BUG_ON(job->reply->reply_payload_rcv_len > rsp_len); > > Maybe convert it to WARN_ON() instead of removing? Sorry, You are absolutely correct should add it back. (With a WARN_ON) > >> /* set reply (bidi) residual */ >> - rsp->data_len = (rsp_len - job->reply->reply_payload_rcv_len); >> + rsp->resid_len = blk_rq_bytes(rsp) - >> + job->reply->reply_payload_rcv_len; > > With the fix-fallouts patchset it, this can be > > rsp->resid_len -= job->reply->reply_payload_rcv_len; > Sure. > Other than above misc points, > > Acked-by: Tejun Heo <tj@xxxxxxxxxx> > Will repost as reply to Original patch, thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html