On Fri, 2009-05-15 at 10:59 -0700, Joe Perches wrote:
> From: Joe Perches <joe@xxxxxxxxxxx>
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/scsi/aha1542.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
> index 8059494..29d5118 100644
> --- a/drivers/scsi/aha1542.c
> +++ b/drivers/scsi/aha1542.c
> @@ -509,9 +509,7 @@ static void aha1542_intr_handle(struct Scsi_Host *shost)
> if (mbistatus == 3)
> continue; /* Aborted command not found */
>
> -#ifdef DEBUG
> - printk(KERN_DEBUG "...done %d %d\n", mbo, mbi);
> -#endif
> + pr_debug("...done %d %d\n", mbo, mbi);
This one looks dangerous ... that's a per trigger printk from interrupt
context. That's a lot of stuff to bung in the log buffer for a normal
operating case (which is pretty interrupt heavy). What does this do to
system responsiveness?
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
