Re: [PATCH 5/5] mvsas: optimization of code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andy Yan wrote:
From 698781e21a8595159a84a8c91b6bfa26d1a99108 Mon Sep 17 00:00:00 2001
From: Andy Yan <ayan@xxxxxxxxxxx>
Date: Mon, 11 May 2009 22:19:25 +0800
Subject: [PATCH 5/5] mvsas: optimization of code

Using sticky field to improve retrieve performance.

Signed-off-by: Ying Chu <jasonchu@xxxxxxxxxxx>
Signed-off-by: Andy Yan <ayan@xxxxxxxxxxx>
Signed-off-by: Ke Wei <kewei@xxxxxxxxxxx>

Please revise this patch, to remove all C casts from a void pointer.

Separately, please submit a patch #6 that audits the rest of the driver, and removes all casts to or from a void pointer.

Rationale:  Standard kernel policy.  Casts to/from void* are

	- unnecessary

	- may hide bugs, if a mistake is made when changing
	  the underlying C type.

The Linux kernel does its best to be "type aware", and we rely heavily on the compiler to warn us of potential problems.


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux