Boaz Harrosh wrote: > Osd library needs to submit pre-allocated bios, form several sources. > osdblk exofs and pNFS-layout driver all have prepared bios for IO submission. > On top of that the osd library needs to append additional segments to the > IO memory, for get/set attributes and more. > > All these are done today by use of a temporary hack - blk_rq_append_bio. > This is bad on few accounts. > 1. blk_rq_append_bio was not meant to be exported and is very specific to its users. > 2. blk_rq_append_bio does not support chained bios. > 3. blk_rq_append_bio does not bounce the bio and therefore current osd implementation > has a bug. > > The proposed solution adds two new fixtures to the block layer, and a corresponding > fixing patch to osd. These are: > > [PATCH 1/4] allow blk_rq_map_kern to append to requests blk_rq_map_kern() part of modification looks good to me. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
