James, This case happens with irq coming late, the device may be gone when the irq is gotten, other cases are in normal stage, lldd_dev won't be null. Regards Andy Yan -----Original Message----- From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Jeff Garzik Sent: 2009年5月9日 6:06 To: James Bottomley Cc: Ying Chu; linux-scsi@xxxxxxxxxxxxxxx Subject: Re: [PATCH 1/4] mvsas: bugfix for NULL pointer execption James Bottomley wrote: > On Fri, 2009-05-08 at 14:15 +0800, Ying Chu wrote: >> >From 347191384292c6e9a9a572c657049bc11615fb82 Mon Sep 17 00:00:00 2001 >> From: Andy <ayan@xxxxxxxxxxx> >> Date: Mon, 4 May 2009 23:29:26 +0800 >> Subject: [PATCH 1/4] mvsas: bug fix, null pointer may be used >> >> Null pointer exception when mvi_dev is null. > > A little more explanation might be helpful. It looks to me that you get > this issue when you have in-flight I/O to a device we've been notified > has gone (because you NULL out lldd_dev in the removal notification > routine). > > In which case, don't we have other races where this can happen, like in > mvs_I_T_nexus_reset()? Agreed... -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html ?韬{.n?????%??檩??w?{.n???{炳??Ф?塄}?财??j:+v?? ? ???2??璀??摺?囤??z夸z罐?+?????w棹f
