Well, thank you. -----Original Message----- From: Jeff Garzik [mailto:jeff@xxxxxxxxxx] Sent: 2009年5月9日 14:52 To: Ying Chu Cc: James Bottomley; linux-scsi@xxxxxxxxxxxxxxx; Andy Yan; Ke Wei Subject: Re: [PATCH 4/4] mvsas: Fine-tuned tags array for alignment Ying Chu wrote: > Hi, James > > DECLARE_BITMAP isn't a good option for mvsas, since the tags array couldn't be global(it's chip-related) and even if we define the static tag array both in mv64xx.c and mv94xx.c, it still couldn't honor 88SE9480 as there are 2 separate cores. So if we use DECLARE_BITMAP, it's hard to maintain the corresponding tag for different core. > > Can we use the following replacement: > - u8 tags[MVS_SLOTS >> 3]; > + unsigned long tags[MVS_SLOTS / BITS_PER_LONG]; You are doing exactly the same thing as DECLARE_BITMAP here, so just use DECLARE_BITMAP :) include/linux/types.h: #define DECLARE_BITMAP(name,bits) \ unsigned long name[BITS_TO_LONGS(bits)] Regards, Jeff ?韬{.n?????%??檩??w?{.n???{炳??Ф?塄}?财??j:+v?? ? ???2??璀??摺?囤??z夸z罐?+?????w棹f
